- 
                Notifications
    
You must be signed in to change notification settings  - Fork 130
 
[SYCL][Fusion] Test kernel fusion and optimization #1535
[SYCL][Fusion] Test kernel fusion and optimization #1535
Conversation
| 
           /verify with intel/llvm#8051  | 
    
012f397    to
    f3e9b09      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the thorough approach to testing this feature, but I believe many of the tests could be simplified - see inline comment for the first few tests. The same idea are applicable to the rest.
f3e9b09    to
    1338ba5      
    Compare
  
    | 
           @aelovikov-intel: Thanks for the fast review and the feedback! I addressed your comments in the latest update and also added some comments here.  | 
    
be5f154    to
    872dadb      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good enough for me. Do you want to add anyone from the spec PR reviewers?
Signed-off-by: Lukas Sommer <lukas.sommer@codeplay.com>
872dadb    to
    87158a2      
    Compare
  
    
          
 IMHO, this is not necessary, as this is testing the approved implementation of the reviewed and approved spec.  | 
    
| 
           @intel/llvm-gatekeepers: As this is approved and all checks passed, could someone merge please?  | 
    
Test different scenarios for kernel fusion, including creation of the fused kernel by the JIT compiler and performance optimizations such as dataflow internalization. Automatically detect availability of the kernel fusion extension in the DPC++ build in `lit.cfg.py` and make it available for `REQUIRES` clauses. Spec: intel/llvm#7098 Implementation: intel/llvm#7831 Signed-off-by: Lukas Sommer <lukas.sommer@codeplay.com>
…uite#1535) Test different scenarios for kernel fusion, including creation of the fused kernel by the JIT compiler and performance optimizations such as dataflow internalization. Automatically detect availability of the kernel fusion extension in the DPC++ build in `lit.cfg.py` and make it available for `REQUIRES` clauses. Spec: intel#7098 Implementation: intel#7831 Signed-off-by: Lukas Sommer <lukas.sommer@codeplay.com>
Test different scenarios for kernel fusion, including creation of the fused kernel by the JIT compiler and performance optimizations such as dataflow internalization.
Automatically detect availability of the kernel fusion extension in the DPC++ build in
lit.cfg.pyand make it available forREQUIRESclauses.Spec: intel/llvm#7098
Implementation: intel/llvm#7831
Signed-off-by: Lukas Sommer lukas.sommer@codeplay.com